Skip to content

chore: Bump NuGet dependencies#1578

Merged
HofmeisterAn merged 1 commit intodevelopfrom
feature/bump-nuget-dependencies
Nov 15, 2025
Merged

chore: Bump NuGet dependencies#1578
HofmeisterAn merged 1 commit intodevelopfrom
feature/bump-nuget-dependencies

Conversation

@HofmeisterAn
Copy link
Collaborator

@HofmeisterAn HofmeisterAn commented Nov 15, 2025

What does this PR do?

This PR updates the NuGet dependencies, specifically Docker.DotNet and removes a Sonar smell.

Why is it important?

-

Related issues

-

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Nov 15, 2025
@netlify
Copy link

netlify bot commented Nov 15, 2025 •
edited
Loading

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 8ef958c
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/69183679deddf60008b60ccb
😎 Deploy Preview https://deploy-preview-1578--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Nov 15, 2025 •
edited
Loading

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated multiple NuGet package dependencies to latest versions, including runtime, testing, and tooling packages.

  • Tests

    • Enhanced test infrastructure for improved test attribution and source tracking.

Walkthrough

Multiple NuGet package versions are incremented in Directory.Packages.props, a constant is introduced for standardization in MosquittoBuilder, and test attribute constructors are enhanced to capture source file path and line number information for better test attribution.

Changes

Cohort / File(s) Summary
Dependency Updates
Directory.Packages.props		 Updated package versions for runtime, testing, and tooling dependencies including BouncyCastle.Cryptography, Docker.DotNet.Enhanced, SSH.NET, Microsoft.NET.Test.Sdk, xunit, Azure.Messaging.ServiceBus, JanusGraph.Net, and Milvus.Client.
Code Refactoring
src/Testcontainers.Mosquitto/MosquittoBuilder.cs		 Introduced local constant allowAnonymous to replace four hardcoded writes of "allow_anonymous true" across MQTT listener configurations.
Formatting
src/Testcontainers/Clients/DockerApiClient.cs		 Added empty line before logging statement in LogContainerRuntimeInfoAsync method.
Test Infrastructure Enhancement
tests/Testcontainers.Platform.Windows.Tests/SkipOnLinuxEngineAttribute.cs, tests/Testcontainers.Platform.Windows.Tests/Usings.cs, tests/Testcontainers.Tests/Unit/Builders/DockerConfigTest.cs		 Updated test attribute constructors to accept CallerFilePath and CallerLineNumber parameters and forward to base FactAttribute. Added global using directive for System.Runtime.CompilerServices and JetBrains.Annotations namespace imports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Test attribute constructor signature changes should be verified to ensure proper parameter forwarding to the base class
  • Consistency of CallerFilePath and CallerLineNumber usage across test attribute implementations

Suggested labels

chore

Poem

🐰 Hopping through versions with care,
Constants declared everywhere,
Test tags now track where they leap,
Code cleaner, logic more deep,
Dependencies fresh, dependencies fair!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The description mentions updating NuGet dependencies and removing a Sonar smell, but lacks details on which packages were updated, the scope of changes beyond Docker.DotNet, and how to test the changes. Expand the description with specific package versions updated, clarify what 'Sonar smell' refers to (the SkipOnLinuxEngineAttribute and SkipIfHostOrContextIsSet changes), and explain testing approach for dependency updates.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: Bump NuGet dependencies' directly relates to the main change of updating multiple NuGet package versions throughout the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/bump-nuget-dependencies
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef955b3 and 8ef958c.

📒 Files selected for processing (6)
  • Directory.Packages.props (3 hunks)
  • src/Testcontainers.Mosquitto/MosquittoBuilder.cs (3 hunks)
  • src/Testcontainers/Clients/DockerApiClient.cs (1 hunks)
  • tests/Testcontainers.Platform.Windows.Tests/SkipOnLinuxEngineAttribute.cs (1 hunks)
  • tests/Testcontainers.Platform.Windows.Tests/Usings.cs (1 hunks)
  • tests/Testcontainers.Tests/Unit/Builders/DockerConfigTest.cs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-08T09:04:00.045Z 
Learnt from: HofmeisterAn
Repo: testcontainers/testcontainers-dotnet PR: 1509
File: tests/Testcontainers.Grafana.Tests/GrafanaContainerTest.cs:45-46
Timestamp: 2025-11-08T09:04:00.045Z
Learning: In xUnit.net test methods in the testcontainers-dotnet project, ConfigureAwait(true) is recommended and correct to use, as it ensures proper synchronization context capture for xUnit's test parallelism management. Do not suggest changing ConfigureAwait(true) to ConfigureAwait(false) in test methods.

Applied to files:

  • tests/Testcontainers.Platform.Windows.Tests/Usings.cs
  • tests/Testcontainers.Tests/Unit/Builders/DockerConfigTest.cs
🧬 Code graph analysis (1)
tests/Testcontainers.Tests/Unit/Builders/DockerConfigTest.cs (2)
src/Testcontainers/Configurations/ICustomConfiguration.cs (13)
  • CanBeNull (18-19)
  • CanBeNull (26-27)
  • CanBeNull (34-35)
  • CanBeNull (42-43)
  • CanBeNull (50-51)
  • CanBeNull (58-59)
  • CanBeNull (66-67)
  • CanBeNull (74-75)
  • CanBeNull (103-104)
  • CanBeNull (111-112)
  • CanBeNull (119-120)
  • CanBeNull (127-128)
  • CanBeNull (135-136)
src/Testcontainers/Builders/DockerConfig.cs (3)
  • CanBeNull (128-153)
  • CanBeNull (162-166)
  • CanBeNull (168-172)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (70)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
  • GitHub Check: ci (Testcontainers.ActiveMq, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Bigtable, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Cassandra, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.BigQuery, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.ArangoDb, ubuntu-24.04)
  • GitHub Check: ci (Testcontainers.Azurite, ubuntu-24.04)
  • GitHub Check: analyze (csharp)
🔇 Additional comments (8)
src/Testcontainers/Clients/DockerApiClient.cs (1)

120-120: LGTM!

The added whitespace improves readability by visually separating the labels block from the logging statement.

src/Testcontainers.Mosquitto/MosquittoBuilder.cs (1)

63-64: Excellent refactoring!

Introducing the allowAnonymous constant eliminates string duplication and ensures consistency across all listener configurations. This addresses the Sonar smell mentioned in the PR description.

Also applies to: 81-81, 87-87, 95-95, 104-104

tests/Testcontainers.Platform.Windows.Tests/Usings.cs (1)

2-2: LGTM!

Adding the global using for System.Runtime.CompilerServices enables the use of caller information attributes ([CallerFilePath], [CallerLineNumber]) across the test project, supporting the test attribution enhancements.

tests/Testcontainers.Platform.Windows.Tests/SkipOnLinuxEngineAttribute.cs (1)

8-11: LGTM!

The constructor enhancement captures source file path and line number information, improving test attribution and debugging capabilities. The optional parameters maintain backward compatibility.

tests/Testcontainers.Tests/Unit/Builders/DockerConfigTest.cs (2)

11-11: LGTM!

The JetBrains.Annotations namespace is needed for the [CanBeNull] attribute used in the constructor parameter.

156-159: LGTM!

The constructor enhancement captures caller information for better test attribution, following the same pattern as SkipOnLinuxEngineAttribute. The optional parameters maintain backward compatibility.

Directory.Packages.props (2)

20-20: No issues found.

Microsoft.NET.Test.Sdk version 18.0.1 exists and is a legitimate, current release on NuGet. The 18.x series represents the latest available versions.

8-9: Docker.DotNet packages verified; manual compatibility review recommended.

Version 3.130.0 is confirmed to exist on NuGet for both Docker.DotNet.Enhanced and Docker.DotNet.Enhanced.X509, with no known security advisories. However, public release notes or changelog information for 3.130.0 is not readily available. Please manually verify compatibility with your codebase by reviewing the package documentation or testing in your development environment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HofmeisterAn HofmeisterAn merged commit 5717a2b into develop Nov 15, 2025
148 checks passed
@HofmeisterAn HofmeisterAn deleted the feature/bump-nuget-dependencies branch November 15, 2025 09:18
This was referenced Dec 6, 2025
Closed
Closed
@coderabbitai coderabbitai bot mentioned this pull request Dec 20, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Feb 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HofmeisterAn