fix: Set Kusto wait strategy encoding to UTF-8#1567
Merged
HofmeisterAn merged 2 commits intotestcontainers:developfrom Nov 9, 2025
Merged
fix: Set Kusto wait strategy encoding to UTF-8#1567HofmeisterAn merged 2 commits intotestcontainers:developfrom
HofmeisterAn merged 2 commits intotestcontainers:developfrom
Conversation
The Kusto wait strategy uses the default encoding. For .NET Framework, this resolves to Windows-1252, which causes the Kusto emulator to return a 415 Media Type not Supported error. In .NET Core, it is UTF-8. This allows .NET Framework tests to run by setting the encoding to always be UTF-8.
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary by CodeRabbit
WalkthroughThe Kusto emulator HTTP request encoding was changed from the platform default (Encoding.Default) to UTF-8 for the JSON payload used in POST requests; the JSON content itself and all other logic remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
HofmeisterAn
approved these changes
Nov 9, 2025
Collaborator
HofmeisterAn
left a comment
There was a problem hiding this comment.
Thanks! That's something we should update across the whole repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Kusto wait strategy uses the default encoding. For .NET Framework, this resolves to Windows-1252, which causes the Kusto emulator to return a 415 Media Type not Supported error. In .NET Core, it is UTF-8.
This allows .NET Framework tests to run by setting the encoding to always be UTF-8.
Why is it important?
Required to use Testcontainers in a .NET Framework app. Otherwise, the Testcontainer waits forever.