fix: Use null-conditional operator to access FinishedAt#1499
Merged
HofmeisterAn merged 1 commit intodevelopfrom Jul 31, 2025
Merged
fix: Use null-conditional operator to access FinishedAt#1499HofmeisterAn merged 1 commit intodevelopfrom
HofmeisterAn merged 1 commit intodevelopfrom
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a NRE that can occur when a container is created with the auto-remove option and then manually stopped. If Docker removes the container, the
_containerfield is set to a default value that lacks a validStateproperty. The fix adds a null-conditional operator to safely accessState.While not perfect, the implementation already falls back to
UtcNow(for theStoppedTimeproperty), so the behavior is preserved. All other accesses toStatewere double-checked and are already NRE-safe.Why is it important?
This change prevents users from encountering unexpected exceptions.
Related issues