feat(Elasticsearch): Return HTTP connection string if security is disabled#1494
Merged
HofmeisterAn merged 1 commit intodevelopfrom Jul 26, 2025
Merged
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
ElasticsearchContainerto take security configurations into account. If HTTPS (security) is disabled, the connection string method will now return an HTTP connection string instead of HTTPS. This change allows for more OOB configurations to be supported.Nonetheless, it's still recommended to extract the certificate and set up proper certificate validation, rather than disabling security.
Why is it important?
Support HTTP configuration OOB.
Related issues