fix: Remove timeout that kills PID 1 when stopping a container#1481
Merged
HofmeisterAn merged 1 commit intodevelopfrom Jul 9, 2025
Merged
fix: Remove timeout that kills PID 1 when stopping a container#1481HofmeisterAn merged 1 commit intodevelopfrom
HofmeisterAn merged 1 commit intodevelopfrom
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the
WaitBeforeKillSecondstimeout that was used to kill PID 1 when stopping the container. It was a leftover from the early implementation of Testcontainers. Using a fixed timeout isn't ideal, as it can vary depending on the environment. If we still need this functionality, we should offer an overload that lets developers pass a custom timeout as an argument.Why is it important?
I believe this is why we're seeing flaky WebDriver tests and why the video isn't being fully written by the FFmpeg container.
Related issues
-