chore: Replace Cake .NET Tool with Cake Frosting#1437
Merged
HofmeisterAn merged 8 commits intotestcontainers:developfrom May 9, 2025
Merged
chore: Replace Cake .NET Tool with Cake Frosting#1437HofmeisterAn merged 8 commits intotestcontainers:developfrom
HofmeisterAn merged 8 commits intotestcontainers:developfrom
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
reviewed
May 9, 2025
Collaborator
There was a problem hiding this comment.
Thanks for the PR. There are a two issues:
- When the build project is added to the solution, the build fails on Windows. It looks like it's trying to build the project again, which causes the failure (removed it from the solution file for now):
error MSB3027: Could not copy "C:\Sources\dotnet\testcontainers-dotnet\build\obj\Debug\net9.0\apphost.exe" to "bin\Debug\net9.0\Testcontainers.Build.exe". Exceeded retry count of 10. Failed. The file is locked by: "Testcontainers.Build (24504)" error MSB3021: Unable to copy file "C:\Sources\dotnet\testcontainers-dotnet\build\obj\Debug\net9.0\apphost. exe" to "bin\Debug\net9.0\Testcontainers.Build.exe". The process cannot access the file 'C:\Sources\dotnet\testcontainers-dotnet\build\bin\Debug\net9.0\Testcontainers.Build.exe' because it is being used by another process. - Also, if you check the build pipeline, it's not running the Windows tests (Windows-hosted runner).
HofmeisterAn
approved these changes
May 9, 2025
Collaborator
HofmeisterAn
left a comment
There was a problem hiding this comment.
Thanks. I updated the GitHub step to use bash and install the SonarScanner again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request migrates from Cake .NET Tool to Cake Frosting.
Why is it important?
From the Cake Runners documentation:
Since the Cake project was already using multiple files, converting it to Cake Frosting makes sense.
I remember debugging a Cake script some years ago and the experience was not really pleasant. Debugging and refactoring becomes really smooth with full IDE support.
Also, as suggested by the maintainer of the Cake Git add-in, using Cake.Frosting.Git instead of Cake.Git solves the issue of LibGit2Sharp failing on Apple Silicon! 🥳 (That was the original motivation behind this pull request.)
Related issues
/cc @digital88
How to test this PR
The Continuous Integration & Delivery workflow has been updated to use Cake Frosting instead of the Cake .NET Tool (i.e. running
./build.shinstead ofdotnet cake) so testing will be done automatically by GitHub actions.