fix(EventHubs): Support default consumer group name#1432
Merged
HofmeisterAn merged 3 commits intotestcontainers:developfrom Apr 23, 2025
Merged
fix(EventHubs): Support default consumer group name#1432HofmeisterAn merged 3 commits intotestcontainers:developfrom
HofmeisterAn merged 3 commits intotestcontainers:developfrom
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3f48434 to
50df079
Compare
HofmeisterAn
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improve the eventHub service configuration builder.
It uses the correct default namespace name, thus removing the warning
It allows to pass an empty consumerGroup array and an array containing
$default. This consumer group is always created by the emulator.It limits the number of hubs that can be created as per the emulator quotas.
In case the configuration is still invalid, it doesn't wait indefinitely on a stopped container.
Why is it important?
In my test cases, I use the constant provided by the SDK
EventHubConsumerClient.DefaultConsumerGroupName(=$default) and it was not possible to configure the container with only this consumer group.Related issues