fix(Redpanda): Add missing command-line arguments to the startup script (smp, memory)#1364
Merged
HofmeisterAn merged 1 commit intotestcontainers:developfrom Feb 9, 2025
Conversation
…memory Command Line argument Values are now consitent with python, go, java, node and ruby implementations: - https://github.com/testcontainers/testcontainers-python/blob/main/modules/kafka/testcontainers/kafka/_redpanda.py - https://github.com/testcontainers/testcontainers-go/blob/main/modules/redpanda/redpanda.go - https://github.com/testcontainers/testcontainers-java/blob/main/modules/redpanda/src/main/java/org/testcontainers/redpanda/RedpandaContainer.java - https://github.com/testcontainers/testcontainers-node/blob/main/packages/modules/redpanda/src/redpanda-container.ts - https://github.com/testcontainers/testcontainers-ruby/blob/main/redpanda/lib/testcontainers/redpanda.rb These updated values adresses the scenario where multiple redpanda test containers instances are wired up and that some containers stop / fail due to resource exhaustion. The following error is captured from the container which has failed: 2025-02-07 09:45:20 WARN 2025-02-07 17:45:20,613 seastar - Requested AIO slots too large, please increase request capacity in /proc/sys/fs/aio-max-nr. available:6559 requested:110260 2025-02-07 09:45:20 Could not initialize seastar: std::runtime_error (Could not setup Async I/O: Not enough request capacity in /proc/sys/fs/aio-max-nr. Try increasing that number or reducing the amount of logical CPUs available for your application)
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
approved these changes
Feb 9, 2025
Collaborator
HofmeisterAn
left a comment
There was a problem hiding this comment.
Thanks for the PR and for referencing the configuration and implementation in other languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issues when multiple concurrent redpanda test containers are running and some fail to startup due to resouce exhaustion
Updated Startup Script to include command line arguments for smp and memory
Command Line argument Values are now consitent with python, go, java, node and ruby implementations:
Why is it important?
These updated values adresses the scenario where multiple redpanda test containers instances are wired up and that some containers stop / fail due to resource exhaustion. The following error is captured from the container which has failed:
Related issues
N/A -> No open issues have been reported