feat: Add Weaviate module#1356
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Done, switched to global usings in Usings files for both the implementation and the tests. Interesting, I use global usings, but via the csproj, not via a separate file typically. |
Xor-el
left a comment
There was a problem hiding this comment.
Looks good to me 🚀
now we wait for @HofmeisterAn review and approval.
|
Thanks @Xor-el! |
HofmeisterAn
left a comment
There was a problem hiding this comment.
Thanks for the PR. I made a few minor changes to align with the repository standard and removed the MSFT copyright header, as I assume that was not intentional.
In addition, I added a GetBaseAddress() method to the container type, allowing us to set the base address for the HTTP client without recreating it repeatedly.
If you're okay with these changes, I'm happy to merge the PR, everything looks good. Thanks again 🙏.
|
Of course! More than fine with the changes, thanks. Feel free to merge. |
|
(I'm assuming the docs here will get updated with it - if you need help with that let me know) |
Thanks for the heads-up. I usually don't check the module catalog, but I will create a PR there. Thanks. |
|
I created a draft PR for the module catalog. I will merge it as soon as we publish the new TC for the .NET version: testcontainers/community-module-registry#106. |
|
@HofmeisterAn thank you very much! I may do a similar PR for Qdrant soon. |
This adds a minimal .NET Testcontainer for Weaviate, the vector database, following the Go and Java testcontainers.