Skip to content

fix: Load PKCS#12 correctly for mTLS on Windows in .NET 9#1320

Merged
HofmeisterAn merged 1 commit intotestcontainers:developfrom
jvmdc:patch-1
Dec 27, 2024
Merged

fix: Load PKCS#12 correctly for mTLS on Windows in .NET 9#1320
HofmeisterAn merged 1 commit intotestcontainers:developfrom
jvmdc:patch-1

Conversation

@jvmdc
Copy link
Contributor

@jvmdc jvmdc commented Dec 20, 2024

What does this PR do?

Fixes loading of PKCS12 for mTLS on WIndows in .NET 9

As documented at https://learn.microsoft.com/en-us/dotnet/fundamentals/syslib-diagnostics/syslib0057#workaround, LoadCertificate does not support PKCS12. PFX files are PKCS12 these days.

Why is it important?

Currently mTLS is broken for Windows in .NET 9

Related issues

@netlify
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 732b595
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67654a661a711500092d429a
😎 Deploy Preview https://deploy-preview-1320--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added the bug Something isn't working label Dec 27, 2024
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@HofmeisterAn HofmeisterAn changed the title fix: Load PKCS12 correctly for mTLS on Windows in .NET 9 fix: Load PKCS#12 correctly for mTLS on Windows in .NET 9 Dec 27, 2024
@HofmeisterAn HofmeisterAn merged commit 48d16b6 into testcontainers:develop Dec 27, 2024
@jvmdc jvmdc deleted the patch-1 branch January 21, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Mutual TLS on Windows in .NET 9 does not work

2 participants