feat: Update docker image to Apache Pulsar 4.0 LTS#1294
Closed
keshramjith wants to merge 4 commits intotestcontainers:developfrom
Closed
feat: Update docker image to Apache Pulsar 4.0 LTS#1294keshramjith wants to merge 4 commits intotestcontainers:developfrom
keshramjith wants to merge 4 commits intotestcontainers:developfrom
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
requested changes
Nov 13, 2024
| public sealed class PulsarBuilder : ContainerBuilder<PulsarBuilder, PulsarContainer, PulsarConfiguration> | ||
| { | ||
| public const string PulsarImage = "apachepulsar/pulsar:3.0.6"; | ||
| public const string PulsarImage = "apachepulsar/pulsar:4.0.0"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| public const string PulsarImage = "apachepulsar/pulsar:4.0.0"; | |
| public const string PulsarImage = "apachepulsar/pulsar:3.0.6"; |
As mentioned in the issue, we don't update the image version unless it is absolutely necessary. We try to maintain backward compatibility.
| .WithPortBinding(PulsarBrokerDataPort, true) | ||
| .WithPortBinding(PulsarWebServicePort, true) | ||
| .WithFunctionsWorker(false) | ||
| .WithCreateParameterModifier(parameterModifier => parameterModifier.User = "root") |
Collaborator
There was a problem hiding this comment.
If this issue is just about permission changes, can't we store the key somewhere else? For example, SecretKeyFilePath = "/pulsar/data/.pulsar/secret.key" should work. This makes the change in PulsarContainer unnecessary too.
Contributor
|
Lack of documentation update if you change the docker version (docs/modules/index.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
apply-config-from-env-with-prefix.pycausing 'standalone' cluster to disappear.Why is it important?
To use the latest version of Apache Pulsar 4.0 LTS to allow developers to take advantage of the new features by having a working testing environment.
Related issues