feat: Add Db2 module#1237
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…d of generating the whole file
…et into kevin0x90-Db2Support
HofmeisterAn
left a comment
There was a problem hiding this comment.
Thank you for the PR and your contribution! I apologize for the delayed review and feedback. I just hadn't found the time earlier. I have a few minor change requests (or questions), but nothing major. I'm happy to merge the PR once those are addressed 🙏.
There was a problem hiding this comment.
Thanks for updating the PR. I've updated the remaining parts. The PR looks good! If you're okay with it, I'm happy to merge it.
I just have one final question: Does it make sense to set any of these configurations as defaults (in Init()) to improve startup performance (or improves development experience)?
.WithEnvironment("TO_CREATE_SAMPLEDB", "false")
.WithEnvironment("PERSISTENT_HOME", "true")
.WithEnvironment("REPODB", "false")
.WithEnvironment("BLU", "false")
.WithEnvironment("HADR_ENABLED", "false")
.WithEnvironment("ARCHIVE_LOGS", "false")
.WithEnvironment("AUTOCONFIG", "false")
Thank you very much for finishing up the PR for the parts I had not addressed yet. Yes it would have some positive effect regarding startup performance but in general the official image takes quite some time to startup even with the optimizations so I’m not sure if it makes a big difference. |
What does this PR do?
Adds a module to use Db2 with testcontainers.
How to test this PR
Automated tests have been added to the project that verify startup and database connectivity.