Skip to content

chore: Use new sshd:1.2.0 image#1160

Merged
HofmeisterAn merged 1 commit intodevelopfrom
mdelapenya-patch-1
Apr 24, 2024
Merged

chore: Use new sshd:1.2.0 image#1160
HofmeisterAn merged 1 commit intodevelopfrom
mdelapenya-patch-1

Conversation

@mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Apr 24, 2024

What does this PR do?

It uses the newest testcontainers/sshd:1.2.0 docker image, which includes the CMD in the image instead of in the code.

Please see testcontainers/sshd-docker#7 for more details.

Why is it important?

Avoid code duplication across testcontainers projects.

Related issues

@mdelapenya mdelapenya added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Apr 24, 2024
@netlify
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 3dea195
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6628d29e12bd9f00081809da
😎 Deploy Preview https://deploy-preview-1160--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya requested a review from HofmeisterAn April 24, 2024 09:42
@mdelapenya mdelapenya added dependencies Pull requests that update a dependency file and removed chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups labels Apr 24, 2024
@HofmeisterAn HofmeisterAn changed the title chore: use new sshd:1.2.0 image chore: Use new sshd:1.2.0 image Apr 24, 2024
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🧡.

@HofmeisterAn HofmeisterAn merged commit fce5672 into develop Apr 24, 2024
@HofmeisterAn HofmeisterAn deleted the mdelapenya-patch-1 branch April 24, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants