Improve CI process & refactor Dockerfile#50
Merged
mdelapenya merged 11 commits intotestcontainers:mainfrom Mar 6, 2023
Merged
Conversation
- update: .dockerignore list - remove: make build for inline execution - remove: make verify
mdelapenya
reviewed
Nov 29, 2022
mdelapenya
reviewed
Nov 29, 2022
mdelapenya
reviewed
Mar 1, 2023
HofmeisterAn
reviewed
Mar 3, 2023
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
mdelapenya
approved these changes
Mar 6, 2023
Member
|
Thanks everybody for this review, I'm merging it now |
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This pull request splits the CI task from the Docker build task, refactors the Dockerfile to build faster from ~126s to ~58s, and upgrades the alpine-linux version to 3.16. This will increase the feedback loop of tests in the build pipeline for contributors.