thread runner: emit missing top level test suite event #351
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: test-unitGH-235, fix test-unitGH-350 This patch will fix the following error: ```console $ ruby test/run.rb --parallel=thread -v Loaded suite test Started (snip) lib/test/unit/ui/console/testrunner.rb:522:in 'String#*': negative argument (ArgumentError) " " * @indent ^^^^^^^ (snip) ``` `TestSuiteThreadRunner.run_all_tests` executes multiple times from `TestUnitTestUtil._run_test`. However The top level test suite event must emit once. `options[:test_suite]` argument does not assigned when executes from `TestUnitTestUtil._run_test`. So the top level test suite event emit once.
kou
reviewed
Dec 18, 2025
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Because `run_tests_recursive` may run some tests immediately. Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Contributor
Author
|
CI has failed as below: It seems that this is unrelated to this change. I'll re run only failed jobs. 3.3 on WindowsCurrent runner version: '2.330.0'
Runner Image Provisioner
Operating System
Runner Image
GITHUB_TOKEN Permissions
Secret source: None
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v6' (SHA:8e8c483db84b4bee98b60c0593521ed34d9990e8)
Download action repository 'ruby/setup-ruby@v1' (SHA:211ffaaa5f8dda97e9e8bca4e70d0fbaf2f8c41c)
Warning: Failed to download action 'https://api.github.com/repos/ruby/setup-ruby/zipball/211ffaaa5f8dda97e9e8bca4e70d0fbaf2f8c41c'. Error: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (codeload.github.com:443)
Warning: Back off 23.465 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/ruby/setup-ruby/zipball/211ffaaa5f8dda97e9e8bca4e70d0fbaf2f8c41c'. Error: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (codeload.github.com:443)
Warning: Back off 27.644 seconds before retry.
Error: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (codeload.github.com:443)3.4 on Windows + Thread:Run ruby/setup-ruby@v1
Downloading msys2 build tools
Error: Error: connect ETIMEDOUT 140.82.116.3:443
at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1611:16) |
Contributor
Author
All CI has been successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: GH-235, fix GH-350
This patch will fix the following error:
TestSuiteThreadRunner.run_all_testsexecutes multiple times fromTestUnitTestUtil._run_test. However The top level test suite event must emit once.options[:test_suite]argument does not assigned when executes fromTestUnitTestUtil._run_test. So the top level test suite event emit once.