Skip to content

Add support .test-unit for default options #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 3 commits into from
Mar 10, 2025
Merged

Add support .test-unit for default options #302

kou merged 3 commits into from
Mar 10, 2025
+13 −0

Conversation

@tikkss
Copy link
Contributor

@tikkss tikkss commented Mar 9, 2025

GitHub: fix GH-300

Prefer .test-unit than test-unit.yml or ~/test-unit.yml

@tikkss
Add support .test-unit for default options
12b8314 
GitHub: fix test-unitGH-300

Prefer `.test-unit` than `test-unit.yml` or `~/test-unit.yml`
kou
kou reviewed Mar 10, 2025
View reviewed changes
tikkss and others added 2 commits March 11, 2025 05:55
@tikkss @kou
Fix a typo
ca069d1 
plaintext ->
plain_text

Co-authored-by: Sutou Kouhei <kou@clear-code.com>
@tikkss @kou
Use a meaningful name
4e66642 
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
@tikkss
Copy link
Contributor Author

tikkss commented Mar 10, 2025

BTW, Should we use Shellwords.shellsplit instead of String#split?

test-unit/lib/test/unit/autorunner.rb

Line 514 in 4e66642

@default_arguments.concat(value.split)

If then I'll open a separate PR.

@kou
Copy link
Member

kou commented Mar 10, 2025

We can't use String#split here because it doesn't work with "quoted argument with space".

@kou kou merged commit 4611076 into test-unit:master Mar 10, 2025
32 checks passed
@tikkss tikkss deleted the add-support-.test-unit branch March 11, 2025 03:09
@tikkss
Copy link
Contributor Author

tikkss commented Mar 11, 2025

We can't use String#split here because it doesn't work with "quoted argument with space".

I see. Thanks for your polite review comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support .test-unit for default options

2 participants

@tikkss @kou