chore: revert "chore: consolidate mieru port configuration (#2277)"#9
Merged
tes-rep merged 1 commit intotes-rep:Alphafrom Sep 28, 2025
Merged
chore: revert "chore: consolidate mieru port configuration (#2277)"#9tes-rep merged 1 commit intotes-rep:Alphafrom
tes-rep merged 1 commit intotes-rep:Alphafrom
Conversation
The `port` field should not be allowed to be set to non-int values, as this would break some downstream assumptions that the option is an int. This reverts commit 1b1f95a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
portfield should not be allowed to be set to non-int values, as this would break some downstream assumptions that the option is an int.This reverts commit 1b1f95a.