Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 51s
• terraform-provider-openstack-acceptance-test : FAILURE in 43m 52s

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 2m 39s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 25m 05s

@jtopjian ready for review

@kayrus I feel like I'm going crazy.

Step 2 of the acceptance test isn't showing that the external_fixed_ip has an update, only enable_snat. Are you seeing the same thing?

Even adding logging statements in the d.HasChange("external_fixed_ip") block isn't showing the logs being made.

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 41s
• terraform-provider-openstack-acceptance-test : FAILURE in 2h 22m 25s

Good catch, I was wondering why these tests have been passed, because I wrote them blindfold, since my environment is not capable to update routes. These tests are also skipped in openlab env, because there is no admin username.

Even adding logging statements in the d.HasChange("external_fixed_ip") block isn't showing the logs being made.

Looks like it is impossible to remove default external_fixed_ip... Besides this field marked as Computed therefore omitting it won't change the plan. Setting an empty list also doesn't give any effects. I've pushed an update to remove the 3rd ext IP. Could you please confirm whether it works for you?

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 2m 48s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 33m 42s

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 2m 36s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 23m 52s

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 2m 05s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 38m 05s

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 47s
• terraform-provider-openstack-acceptance-test : FAILURE in 2h 32m 32s

@jtopjian can you run acceptance tests against your environment?

@jtopjian I managed to run tests in my env. And I have some bad news:

1. TypeList considers ordering, and when we have more than one external_fixed_ip, terraform tries to update the router
2. We need to switch the external_fixed_ip to TypeMap with the hashing based on the subnet_id. If there is no custom hashing func, the computed ip_address will trigger the diff, and terraform will suggest to update the router
3. Custom hashing func based on the subnet_id will ignore any ip_address modifications made by user, update func won't work on ip_address modification.

@kayrus Thank you for the notes and for looking into this. I will review and see if I come to similar conclusions when I get some time. :)

@kayrus I know I'm behind on this, but I have not forgotten about it.

I'm sorry for the delay. I had some time to review this.

The problem you're describing already exists: if you declare multiple external_fixed_ip blocks and set the subnet_id and ip_address of both and if they are returned in a different order, there will be a diff.

I think there are two problem statements here:

1. Being able to specify an external_fixed_ip without an ip_address. This is what How does ip_address in external_fixed_ip argument of openstack_networking_router_v2 get calculated? #449 is reporting.
2. Declaring multiple external_fixed_ip blocks. This problem already exists.

Since no one has reported 2 yet, I have to wonder if anyone is declaring multiple external_fixed_ip blocks to begin with -- is there a legitimate use for this? I'm not trying to say the problem isn't valid, but since this problem already exists, is there anything preventing us from fixing #449 and looking at this second issue separately?

If we were to look at this second problem, we would not change external_fixed_ip to a TypeMap. It's a clever idea, but it's too much of a breaking change. We'll need to either look into a CustomizeDiff or create a separate resource to handle a router's gateway information.

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

Build failed.

• terraform-provider-openstack-unittest : FAILURE in 3m 10s
• terraform-provider-openstack-acceptance-test : FAILURE in 37m 44s

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 3m 39s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 30m 25s

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 3m 43s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 29m 05s

@ozerovandrei I think this is ready to be merged. Other related issues are addressed in #922, since there is no easy way to fix them.

Build failed.

• terraform-provider-openstack-unittest : RETRY_LIMIT in 11m 29s
• terraform-provider-openstack-acceptance-test : RETRY_LIMIT in 3h 09m 28s

recheck

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 3m 40s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 18m 25s