vpnaas: add support for more ciphers (auth, encryption, pfs modes)#1851
Merged
kayrus merged 4 commits intoterraform-provider-openstack:mainfrom May 2, 2025
Merged
Conversation
Collaborator
|
@bpetermannS11 thanks for the PR. can you update the docs to reflect the added ciphers? |
Collaborator
|
@bpetermannS11 can you rebase on main? |
e10a85e to
d7a15df
Compare
kayrus
reviewed
Apr 29, 2025
Collaborator
kayrus
left a comment
There was a problem hiding this comment.
I just realized that resourceIPSecPolicyV2EncryptionAlgorithm, resourceIPSecPolicyV2AuthAlgorithm and resourceIPSecPolicyV2PFS and other functions are not used in the arguments schema to check the validity.
Can you convert these functions into a format, which matches the ValidateFunc and use it there? This will allow to catch human error on early stage.
For VPNaaS IKE policies and IPSEC policies several choices for encryption algorithms, auth algorithms and PFS modes have been added. Encryption algorithms: add AES CCM mode and AES GCM mode variants for 128/192/256 bit keys and 8/12/16 octet ICVs. Add AES CTR modes for 128/192/256 bit keys. Auth algorithms: add aes-xcbc and aes-cmac. PFS: add Diffie Hellman groups 15 to 31. Closes: terraform-provider-openstack#1850
Encryption algorithms: add AES CCM mode and AES GCM mode variants for 128/192/256 bit keys and 8/12/16 octet ICVs. Add AES CTR modes for 128/192/256 bit keys. Auth algorithms: add aes-xcbc and aes-cmac. PFS: add Diffie Hellman groups 15 to 31.
Validate auth_algorithm, encryption_algorithm, pfs arguments of ipsec policies and ike policies. Use the same maps for validation and for mapping the input string.
61fce32 to
cb4b426
Compare
9ad8d96 to
32374da
Compare
kayrus
approved these changes
May 2, 2025
Collaborator
kayrus
left a comment
There was a problem hiding this comment.
LGTM, thanks! I adjusted validation funcs in a simpler way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For VPNaaS IKE policies and IPSEC policies several choices for encryption algorithms, auth algorithms and PFS modes have been added.
Encryption algorithms: add AES CCM mode and AES GCM mode variants for 128/192/256 bit keys and 8/12/16 octet ICVs. Add AES CTR modes for 128/192/256 bit keys.
Auth algorithms: add aes-xcbc and aes-cmac.
PFS: add Diffie Hellman groups 15 to 31.
Requires updating gophercloud to v2.7.0.
Closes: #1850