Update suggested permissions for .shortcuts/icons/#69
Update suggested permissions for .shortcuts/icons/#69agnostic-apollo merged 2 commits intotermux:masterfrom
Conversation
Change the `chmod` command suggested for the `~/. shortcuts/icons/` directory from `600` to `700`. Without `u+x`, users are not able to `cp` files into the directory.
|
I created Issue #68 to document this PR. (I can't find the button to link the PR to the Issue, so I am just mentioning it in a comment.) |
agnostic-apollo
left a comment
There was a problem hiding this comment.
Thanks for noticing the mistake for the wrong directory permission but change the command to chmod -R a-x,u=rwX,go-rwx /data/data/com.termux/files/home/.shortcuts/icons. It was originally done so that icon files didn't have execute permissions. This will result in directories having 700 and files having 600.
|
This is a sample command in a walkthrough creating the directory with no contents, so the proposed change to the chmod would (in theory) have no effect, since it only affects the directory and its current contents. The example command is, however, written in a way such that it won't cause an error if the directory exists ( Perhaps the tutorial's sample commands should be rewritten to not be so graceful, so as to prevent making any existing files executable? To be really safe, I think the app itself would need to be modified to scan for permissions and refuse to proceed if unsafe executable flags are set. |
|
Well, if the directory didn't exist, then obv It's our responsibility to just tell user what correct permissions are, specially considering some run selinux in permissive mode too. Rest is on them. Images have no reason to be executable, so any existing files under existing directory would get fixed. Script execution permissions are in fact checked and only fixed if its under shortcuts directory. Termux:Tasker allows scripts outside tasker directory, so that directory check is more useful for it.
I didn't get you, can you explain. |
Fix the `chmod` command suggested for the `~/. shortcuts/icons/` directory. Previously it would not allow users to copy files into the directory.
SuspectTyrannosaurus
left a comment
There was a problem hiding this comment.
I made the change recommended. In the odd case where someone has already created and populated the directory before running the command to create it, the pre-existing files should be set with the most appropriate permissions.
|
Sorry, forgot about this. Merging. Thanks again! |
Change the
chmodcommand suggested for the~/. shortcuts/icons/directory from600to700. Withoutu+x, users are not able tocpfiles into the directory.