Merged
Conversation
- Fixes termux#26707 - Revert fish-shell/fish-shell@70bd49f as planned and previously noted in termux#26466 - After fish-shell/fish-shell@eb4cec1, `fix-import-when-posix-spawn-disabled.patch` is necessary to prevent compilation error `failed to resolve: use of undeclared type 'Pid'` - After fish-shell/fish-shell@91ee45b, `revert-6644cc9.patch` is no longer necessary to prevent a compilation failure, and can be removed. - termux/termux-app#4417 has been in [Termux 0.118.3](https://github.com/termux/termux-app/releases/tag/v0.118.3) for 4 months, meaning that `status test-feature keyboard-protocols && set -U fish_features no-keyboard-protocols` can be removed.
Member
Author
|
I will merge it in 24 hours if no problems are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Auto update failing for fish #26707
Revert fish-shell/fish-shell@70bd49f as planned and previously noted in bump(main/fish): 4.0.6 #26466
After fish-shell/fish-shell@eb4cec1,
fix-import-when-posix-spawn-disabled.patchis necessary to prevent compilation errorfailed to resolve: use of undeclared type 'Pid'After fish-shell/fish-shell@91ee45b,
revert-6644cc9.patchis no longer necessary to prevent a compilation failure, and can be removed.Fixed: fully consume unknown CSI sequences containing non-numeric parameter byte termux-app#4417 has been in Termux 0.118.3 for 4 months, meaning that
status test-feature keyboard-protocols && set -U fish_features no-keyboard-protocolscan be removed.