Fixed: Make ScrollDown escape respect margins#3005
Conversation
|
@Fparisa166 You can install an Or just wait until an official update to Termux. |
21804bc to
3f7a939
Compare
|
Just poking, this PR hasn't been merged for over 3 months. |
|
@evg-zhabotinsky I am guessing @agnostic-apollo has already merged this locally and will push it as part of the upcoming 0.119 update, considering the force-pushes above |
|
The force push was for |
SD sequence (`${CSI}${N}T`) was scrolling the whole width
of the terminal instead of just between the margins.
RI sequence (`${ESC}M`, move cursor up 1 line) was doing the same.
Fixed that.
Fixes termux#2576 where in tmux scrolling one of several
side-by-side panels down resulted in all visually scrolling.
|
Thanks! I've added tests for this in Seems that recent tmux versions no longer triggers this buggy (perhaps working around broken terminal emulators, as the mac terminal had the same issue), but this change indeed seems like a correct one, and aligns us with xterm and other more actively maintained terminals. |
SD sequence (
${CSI}${N}T) was scrolling the whole widthof the terminal instead of just between the margins.
RI sequence (
${ESC}M, move cursor up 1 line) was doing the same. Fixed that.Fixes #2576 where in tmux scrolling one of several
side-by-side panels down resulted in all visually scrolling.