True italic fonts.#2829
Conversation
True italics are enabled if a font-italic.ttf is present in
${HOME}/.termux folder, if this file not exists fallback to default
behaviour of italics.
It's very difficult to notice and explain, but it occurs when the cursor is blinking over an italic text it's "shrunken", this is more visible with slashes.
|
If this PR is merged please add a corresponding tip here: |
@j0ng4b I couldn't understand that. Can you provide an example? I tried this PR with two different fonts and it works:
|
This is most related to the For example, the fonts with the same or almost the same dimensions: When mixing the italic text and normal text everything goes well in this case, but when using fonts with different dimensions this is the result:
On the two images the result is different because the base (non-italic) font width used to do the math before draw change in the two fonts. |
|
Why is this not merged? This works perfect. |
|
|
|
|
Waiting for this project to be fixed and merged |
|
@j0ng4b @agnostic-apollo can this be merged? |
21804bc to
3f7a939
Compare
|
Waiting for this PR merge conflicts to be resolved to see if it fixes my italic clipping issues with neovim. Any progress? |
|
Hopefully it's fixed soon |
|
Please, resolve the conflicts 🙏 |
|
For anyone who wants to build, the PR is still working, there's very simple conflicts |
|
Any updates? |
|
When I get some time I'll work on improve this (maybe add true bold fonts) and fix the conflicts. |
|
Hey, are there any updates on this? |
|
i think bro forgot about this |
Help requested, |
| mRenderer = new TerminalRenderer(mRenderer.mTextSize, newTypeface, newItalicTypeface); | ||
| updateSize(); | ||
| invalidate(); | ||
| } |
There was a problem hiding this comment.
So i have to build the whole thing with this PR?
Closes #711. Adds support to true italic fonts. If an italic font file (
~/.termux/font-italic.ttf) not exists, fallback to previous italic effect.One thing that maybe can be an issue is to use two different kinds of fonts. This isn't easy to handle with my current knowledge of the code then should be avoided if possible (sane people will not use two different fonts, I hope...).