BackgroundJob command result responses#1365
Merged
fornwall merged 2 commits intotermux:masterfrom Jan 5, 2020
Merged
Conversation
This commit adds an optional final argument to the BackgroundJob constructor for a PendingIntent to return the results of its execution to, and also attempts to pass an optional pendingIntent to it from the Service start intent
9bbd1d4 to
f16e579
Compare
Contributor
Author
|
(The push was rebasing this onto master's new commits) |
Member
|
@Archenoth Thanks a lot! This change will be part of version 0.86 of the Termux app, which will be released within a day. You're welcome to join https://gitter.im/termux/dev to discuss development (and ping me if I'm slow to merge any PR)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an optional final argument to the BackgroundJob constructor for a
PendingIntentthat it will respond to with the results of the commands that it has run. (A "result" bundle containing stdout, stderr, and the process exit status)I've also added a
"pendingIntent"extra that will be pulled fromservice_executerequests that can hold these new PendingIntents, so Termux can respond to things that can invoke these intents with the resulting command's output.The immediate practicality of this is that it will allow things like this issue in termux-tasker to be solved.