Attempt to fix bootstrap installation failure that may be caused by invalid mkdirs return value

agnostic-apollo · agnostic-apollo · commit dc8bdfe675be · 2021-07-08T10:50:30.000+05:00
diff --git a/termux-shared/src/main/java/com/termux/shared/file/FileUtils.java b/termux-shared/src/main/java/com/termux/shared/file/FileUtils.java
@@ -326,9 +326,10 @@ public static Error validateDirectoryFileExistenceAndPermissions(String label, f
                     if (createDirectoryIfMissing && fileType == FileType.NO_EXIST) {
                         Logger.logVerbose(LOG_TAG, "Creating " + label + "directory file at path \"" + filePath + "\"");
                         // Create directory and update fileType if successful, otherwise return with error
-                        if (file.mkdirs())
-                            fileType = getFileType(filePath, false);
-                        else
+                        // It "might" be possible that mkdirs returns false even though directory was created
+                        boolean result = file.mkdirs();
+                        fileType = getFileType(filePath, false);
+                        if (!result && fileType != FileType.DIRECTORY)
                             return FileUtilsErrno.ERRNO_CREATING_FILE_FAILED.getError(label + "directory file", filePath);
                     }
 
