Fixed: Fix ArrayIndexOutOfBoundsException thrown because length was less than 0 when selecting text from terminal buffer

agnostic-apollo · agnostic-apollo · commit 03e31d190d17 · 2024-06-18T03:20:09.000+05:00
java.lang.ArrayIndexOutOfBoundsException: src.length=132 srcPos=90 dst.length=16 dstPos=0 length=-2
at java.lang.System.arraycopy(System.java:469)
at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:597)
at java.lang.StringBuilder.append(StringBuilder.java:191)
at com.termux.terminal.TerminalBuffer.getSelectedText(TerminalBuffer.java:97)
at com.termux.terminal.TerminalBuffer.getSelectedText(TerminalBuffer.java:57)
at com.termux.terminal.TerminalBuffer.getSelectedText(TerminalBuffer.java:53)
at com.termux.terminal.TerminalEmulator.getSelectedText(TerminalEmulator.java:2401)
at com.termux.view.textselection.TextSelectionCursorController$1.onActionItemClicked(TextSelectionCursorController.java:140)
diff --git a/terminal-emulator/src/main/java/com/termux/terminal/TerminalBuffer.java b/terminal-emulator/src/main/java/com/termux/terminal/TerminalBuffer.java
@@ -93,8 +93,11 @@ public String getSelectedText(int selX1, int selY1, int selX2, int selY2, boolea
                     if (c != ' ') lastPrintingCharIndex = i;
                 }
             }
-            if (lastPrintingCharIndex != -1)
-                builder.append(line, x1Index, lastPrintingCharIndex - x1Index + 1);
+
+            int len = lastPrintingCharIndex - x1Index + 1;
+            if (lastPrintingCharIndex != -1 && len > 0)
+                builder.append(line, x1Index, len);
+
             boolean lineFillsWidth = lastPrintingCharIndex == x2Index - 1;
             if ((!joinBackLines || !rowLineWrap) && (!joinFullLines || !lineFillsWidth)
                 && row < selY2 && row < mScreenRows - 1) builder.append('\n');

Original file line number	Diff line number	Diff line change
`@@ -93,8 +93,11 @@ public String getSelectedText(int selX1, int selY1, int selX2, int selY2, boolea`
`93`	`93`	`if (c != ' ') lastPrintingCharIndex = i;`
`94`	`94`	`}`
`95`	`95`	`}`
`96`		`- if (lastPrintingCharIndex != -1)`
`97`		`- builder.append(line, x1Index, lastPrintingCharIndex - x1Index + 1);`
	`96`	`+`
	`97`	`+ int len = lastPrintingCharIndex - x1Index + 1;`
	`98`	`+ if (lastPrintingCharIndex != -1 && len > 0)`
	`99`	`+ builder.append(line, x1Index, len);`
	`100`	`+`
`98`	`101`	`boolean lineFillsWidth = lastPrintingCharIndex == x2Index - 1;`
`99`	`102`	`if ((!joinBackLines \|\| !rowLineWrap) && (!joinFullLines \|\| !lineFillsWidth)`
`100`	`103`	`&& row < selY2 && row < mScreenRows - 1) builder.append('\n');`