Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 4 +1
Lines 116 125 +9
=========================================
+ Hits 116 125 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hugovk
requested changes
Apr 22, 2023
Member
hugovk
left a comment
There was a problem hiding this comment.
Thanks for the PR! Here's a couple of suggestions.
|
any way this could be merged? this seems like an amazing upgrade for usability, and the only blocker seems to be impossible to do in the current state of python typing. |
Member
|
Thanks for ping. If the conflicts are resolved, I'll take another look. |
hugovk
approved these changes
Oct 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes to the declared type signatures:
cprint("hello", "orange")will result incoloredandcprintwas relaxed to acceptobjects and not juststrings. This makescprintmore in line withprint, which accepts arbitrary objects and fixes the example in README which readserror: Argument 1 to "cprint" has incompatible type "int"; expected "str"when running through mypy.