Add true colour RGB option as input arguments#102
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 97.65% 97.79% +0.13%
==========================================
Files 3 3
Lines 128 136 +8
==========================================
+ Hits 125 133 +8
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hugovk
left a comment
There was a problem hiding this comment.
Please could you add tests and an example to the README?
specify that ints are 0-255 Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
this spans all 256**3 permutations
256**3 permutations was too ridiculously long
for more information, see https://pre-commit.ci
|
I've added tests for the README has also been edited as requested. |
Yeah, just a couple of representative values are fine 😅
Thanks! |
|
Cool, hope to see it merged! Am looking to use this in my own mini libraries. |
Hi there, I really like this package but wanted the ability to print in any arbitrary RGB colour. Since most terminals now (even Windows Terminal) allow for 24-bit RGB, I think this would be a useful addition.
I'm not sure what else I would need to change for this to be accepted (or if this is even desired as a feature). Let me know and I'll amend it!
Preview of the feature (added to main.py):