Define a list of browsers for the BrowserStack-benchmark tool#3737
Merged
Linchenn merged 3 commits intotensorflow:masterfrom Aug 6, 2020
Linchenn:available-browsers
Merged
Define a list of browsers for the BrowserStack-benchmark tool#3737Linchenn merged 3 commits intotensorflow:masterfrom Linchenn:available-browsers
Linchenn merged 3 commits intotensorflow:masterfrom
Linchenn:available-browsers
Conversation
pyu10055
approved these changes
Aug 6, 2020
| { | ||
| "os": "ios", | ||
| "os_version": "13", | ||
| "browser": "iphone", |
Collaborator
There was a problem hiding this comment.
can the browser type be specified for iphone/ipad or android? maybe as safari or chrome?
Collaborator
Author
There was a problem hiding this comment.
No, currently it is not tunable for mobile devices. (for android, the browser is Chrome; for ios, the browser is Safari)
lina128
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We selected 61 combinations between os, os_version, browser, browser_version, device. (Windows 4, OS X 3, android 33, ios 21).
If you want to use new rules to filter out the list of combinations, or, you want to get the full configuration for a certain combination, you can use the following tool:
availableBrowsersis an array of all combinations.) Then runnode app.js, thenbrowser_list.jsonis the updated combination list.node app.jsand open http://localhost:8001/ (the webpage includes all available combinations), you can see things like:To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is