Skip to content

Define a list of browsers for the BrowserStack-benchmark tool#3737

Merged
Linchenn merged 3 commits intotensorflow:masterfrom
Linchenn:available-browsers
Aug 6, 2020
Merged

Define a list of browsers for the BrowserStack-benchmark tool#3737
Linchenn merged 3 commits intotensorflow:masterfrom
Linchenn:available-browsers

Conversation

@Linchenn
Copy link
Collaborator

@Linchenn Linchenn commented Aug 6, 2020

We selected 61 combinations between os, os_version, browser, browser_version, device. (Windows 4, OS X 3, android 33, ios 21).

If you want to use new rules to filter out the list of combinations, or, you want to get the full configuration for a certain combination, you can use the following tool:

git clone https://github.com/tensorflow/tfjs.git
cd tfjs/e2e/benchmarks/browserstack-benchmark
git checkout select-BrowserStack-browsers
yarn install

export BROWSERSTACK_USERNAME=YOUR_USERNAME
export BROWSERSTACK_ACCESS_KEY=YOUR_ACCESS_KEY
  • If you want to use new rules, you can override the selectBrowsers function with your rules. (the availableBrowsers is an array of all combinations.) Then run node app.js, then browser_list.json is the updated combination list.
  • If you want to get the full configuration for a certain combination, you can run node app.js and open http://localhost:8001/ (the webpage includes all available combinations), you can see things like:
    Screen Shot 2020-08-05 at 8 37 17 PM

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

{
"os": "ios",
"os_version": "13",
"browser": "iphone",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the browser type be specified for iphone/ipad or android? maybe as safari or chrome?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, currently it is not tunable for mobile devices. (for android, the browser is Chrome; for ios, the browser is Safari)

@Linchenn Linchenn requested a review from lina128 August 6, 2020 15:45
@Linchenn Linchenn merged commit 4707c3c into tensorflow:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants