PR #22901: Remove transpose from reshape builder#88004
Merged
copybara-service[bot] merged 1 commit intomasterfrom Feb 28, 2025
Merged
PR #22901: Remove transpose from reshape builder#88004copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
d0377d9 to
a390f89
Compare
Imported from GitHub PR openxla/xla#22901 Reshape builder unnecessarily accepts two arguments: 1. `dimensions` which permutation of the layoyt of the shape. 2. `new_sizes` which are the new dimensions of the shape. This is confusing, and the we can simply remove the support for permutation of layout - as it is just a transpose and such a transpose can be easily constructed wherever required. Copybara import of the project: -- b44dc317188053cd51b7af4e90598ba357ba1197 by Shraiysh Vaishay <svaishay@nvidia.com>: Remove transpose from reshape builder Reshape builder unnecessarily accepts two arguments: 1. `dimensions` which is the "layout" of the shape. 2. `new_sizes` which is the "dimensions" of the shape. This is confusing, and the we can simply remove the support for layout - as it is just a transpose and such a transpose can be easily constructed wherever required. -- a7100cfc2185f5b8fd9dcf6dfa52c221b195021c by Shraiysh Vaishay <svaishay@nvidia.com>: Fix unrelated clang-format issues in xla/python/ops.cc -- b25041292522834a544b2c7c463909fc576c4ba9 by Shraiysh Vaishay <svaishay@nvidia.com>: Fix semantics doc Merging this change closes #22901 PiperOrigin-RevId: 732082186
a390f89 to
12c51d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #22901: Remove transpose from reshape builder
Imported from GitHub PR openxla/xla#22901
Reshape builder unnecessarily accepts two arguments:
dimensionswhich permutation of the layoyt of the shape.new_sizeswhich are the new dimensions of the shape.This is confusing, and the we can simply remove the support for permutation of layout - as it is just a transpose and such a transpose can be easily constructed wherever required.
Copybara import of the project:
--
b44dc317188053cd51b7af4e90598ba357ba1197 by Shraiysh Vaishay svaishay@nvidia.com:
Remove transpose from reshape builder
Reshape builder unnecessarily accepts two arguments:
dimensionswhich is the "layout" of the shape.new_sizeswhich is the "dimensions" of the shape.This is confusing, and the we can simply remove the support for
layout - as it is just a transpose and such a transpose can be
easily constructed wherever required.
--
a7100cfc2185f5b8fd9dcf6dfa52c221b195021c by Shraiysh Vaishay svaishay@nvidia.com:
Fix unrelated clang-format issues in xla/python/ops.cc
--
b25041292522834a544b2c7c463909fc576c4ba9 by Shraiysh Vaishay svaishay@nvidia.com:
Fix semantics doc
Merging this change closes #22901
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#22901 from shraiysh:fix_reshape_and_shape_inference b25041292522834a544b2c7c463909fc576c4ba9