Skip to content

Conversation

@caisq
Copy link
Contributor

@caisq caisq commented Feb 2, 2017

No description provided.

Zongheng Yang and others added 30 commits February 1, 2017 12:05
This seems like a reasonable thing to do, as (1) they have been in existence for ~1 year, (2) people have added new fields to them since their inception, and (3) the C API supports them.
Change: 146271432
We create a reservoir that organizes health pill values by node name. Also added a
method onto the event multiplexor to fetch the health pills per run.
Change: 146272468
…py insertion HLO passes. Switches implementation to use simple expression tree matching, and reduces the number of patterns to match to those that we care about in production (i.e. post fusion and copy insertion).

// ExecuteThunks runtime FRNN forward pass (sequence_length=30)  WhileThunk: 112ms

// ExecuteThunks runtime FRNN forward pass (sequence_length=30)  ForThunk:     6ms

// ExecuteThunks runtime FRNN forward pass (sequence_length=100) WhileThunk: 585ms

// ExecuteThunks runtime FRNN forward pass (sequence_length=100) ForThunk:   191ms
Change: 146273048
Resource variables are quite new, so this change should not affect any preexisting models. Follows up on the fix for Optimizers dealing with sparse gradients which have repeated indices.
Change: 146279378
…ch is not numerically accurate for x near 0).

Make some cleanups to unary_ops_test.py.
Change: 146282294
…ll actions: training, evaluation, inference, serving.

Change: 146285386
- Create the directory if it doesn't exist
- Output formatted code
Change: 146286990
…delete unused methods in contrib metrics.

Change: 146294596
- Register attribute and op renames
Change: 146298778
- Marked control flow ops as hidden
Change: 146300232
Comment out all the overrides except what was in the
first iteration of the change. Enable them after we've
ensured there are no build breakages.
Change: 146309050
Also makes resource variables dense-tensor-like.
Change: 146310220
The better fix is to add Windows support to ParseURI, but that requires more significant changes, so leaving it as a TODO for now.
Change: 146314223
…'s currently exposed in Python

Change: 146314254
Change: 146316019
Change: 146316196
martinwicke and others added 9 commits February 1, 2017 19:45
test_log_output_filename. This lets us create test_log_output_filename
automatically if it is not passed in.
Change: 146320874
Change: 146327228
Fixes the problem of XLA being unable to find libdevice files if not executed
through bazel. For example,
http://stackoverflow.com/questions/41729019/notfounderror-running-tensorflow-xla-example-libdevice-compute-35-10-bc/41800414#41800414
Change: 146329331
commented out plus some new overrides.
Change: 146330232
Resolved conflicts in:
tensorflow/contrib/slim/python/slim/learning_test.py
@caisq caisq mentioned this pull request Feb 2, 2017
@caisq
Copy link
Contributor Author

caisq commented Feb 2, 2017

@martinwicke Any thoughts on the test failure of parser_test under Python 3?

FAIL: //tensorflow/tools/docs:parser_test (see /var/lib/jenkins/workspace/tensorflow-pull-requests-cpu-python3/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/workspace/bazel-out/local-py3-opt/testlogs/tensorflow/tools/docs/parser_test/test.log).
INFO: From Testing //tensorflow/tools/docs:parser_test:
==================== Test output for //tensorflow/tools/docs:parser_test:
....FF.....

FAIL: test_generate_index (main.ParserTest)

Traceback (most recent call last):
File "/var/lib/jenkins/workspace/tensorflow-pull-requests-cpu-python3/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/workspace/bazel-out/local-py3-opt/bin/tensorflow/tools/docs/parser_test.runfiles/org_tensorflow/tensorflow/tools/docs/parser_test.py", line 287, in test_generate_index
self.assertTrue('a_method' not in docs)
AssertionError: False is not true

======================================================================
FAIL: test_generate_markdown_for_class (main.ParserTest)

Traceback (most recent call last):
File "/var/lib/jenkins/workspace/tensorflow-pull-requests-cpu-python3/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/workspace/bazel-out/local-py3-opt/bin/tensorflow/tools/docs/parser_test.runfiles/org_tensorflow/tensorflow/tools/docs/parser_test.py", line 120, in test_generate_markdown_for_class
self.assertTrue('a_method(arg='default')' in docs)
AssertionError: False is not true


Ran 11 tests in 0.004s

FAILED (failures=2)

@martinwicke
Copy link
Member

Tests are re-running on the other push. Sorry, I couldn't finish it last night.

@martinwicke martinwicke closed this Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.