Skip to content

Run pytest targets without compiling#50163

Closed
bhack wants to merge 2 commits intotensorflow:masterfrom
bhack:pytest_without_compile
Closed

Run pytest targets without compiling#50163
bhack wants to merge 2 commits intotensorflow:masterfrom
bhack:pytest_without_compile

Conversation

@bhack
Copy link
Contributor

@bhack bhack commented Jun 9, 2021

This will add a specific --targets flag to specific user test targets.

E.g.
./tensorflow/tools/ci_build/builds/run_pip_tests.sh --targets /tensorflow/python/eager:def_function_test

./tensorflow/tools/ci_build/builds/run_pip_tests.sh --targets /tensorflow/python/eager:all

See https://discuss.tensorflow.org/t/run-python-tests-without-compiling-tf

/cc @angerson @perfinion @mihaimaruseac What kind of extra checks we need to add to promote this in Doc as a temp workaround for python PRs?

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jun 9, 2021
@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@gbaned gbaned self-assigned this Jun 9, 2021
@gbaned gbaned requested a review from cheshire June 9, 2021 04:56
@mihaimaruseac mihaimaruseac requested review from angerson, mihaimaruseac and perfinion and removed request for cheshire June 9, 2021 16:35
@mihaimaruseac
Copy link
Contributor

This LGTM, but waiting on Austin and Jason too.

@bhack
Copy link
Contributor Author

bhack commented Jun 9, 2021

What we need to do to use python files in the checkout other then tests?
Generally with a PR you edit both the python source of the feature/bug and the related tests.

@bhack
Copy link
Contributor Author

bhack commented Jun 9, 2021

@mihaimaruseac Thanks for the review but I am going to close this as in TF bazel BUILD files we don't have a clear separation between python an c++ targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes size:S CL Change Size: Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants