Skip to content

[Graph C API] Updating warning messages #47969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
copybara-service merged 1 commit into from
Mar 25, 2021
Merged

[Graph C API] Updating warning messages #47969

copybara-service merged 1 commit into from
Mar 25, 2021

Conversation

@Solaryee
Copy link
Contributor

@Solaryee Solaryee commented Mar 22, 2021

This is a following PR of #47635 to print warnings more accurately, which can improve user experience:

  1. In some scenarios, warning messages is not printed since config's default value is not considered. It is fixed in this MR.
  2. Instead of printing all configs, printing conflicted configs only.

An example of warnings:

2021-03-22 13:08:42.718436: W tensorflow/core/grappler/optimizers/meta_optimizer.cc:609] User's config has been changed based on plugin's config.
2021-03-22 13:08:42.718446: W tensorflow/core/grappler/optimizers/meta_optimizer.cc:610] 
Config of optimizers		User's config	Plugin's config	Final config(User & Plugin)
layout_optimizer                1		0		0
remapping                       1		0		0

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Mar 22, 2021
@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@Solaryee
Copy link
Contributor Author

Solaryee commented Mar 22, 2021

@penpornk @ezhulenev Sorry for the inconvenience that I missed some cases in the 3rd PR of Graph C API. This PR only changes warning messages, and does not change the basic logic of plugin optimizer. Please have a review. Thanks.

@gbaned gbaned self-assigned this Mar 22, 2021
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Mar 22, 2021
@gbaned gbaned requested a review from ezhulenev March 22, 2021 11:08
@Solaryee
Copy link
Contributor Author

Solaryee commented Mar 24, 2021

@penpornk @ezhulenev Could you please have a review on this PR? I think there is no big change, only some updates on warning messages.

penpornk
penpornk approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 25, 2021
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Mar 25, 2021
@copybara-service copybara-service bot merged commit 19a2594 into tensorflow:master Mar 25, 2021
@penpornk
Copy link
Member

penpornk commented Mar 25, 2021

This PR broke a test and was reverted earlier today (3c462a9) and I haven't had a chance to bring it back. So, unfortunately, it will miss the 2.5 branch cut. Sorry about that. :(

@Solaryee
Copy link
Contributor Author

Solaryee commented Mar 26, 2021

This PR broke a test and was reverted earlier today (3c462a9) and I haven't had a chance to bring it back. So, unfortunately, it will miss the 2.5 branch cut. Sorry about that. :(

It's fine. This is not a critical PR, and plugin optimizer still works without it. Please let me know if there is needed form my side. :)

This was referenced Apr 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penpornk penpornk penpornk approved these changes

@ezhulenev ezhulenev Awaiting requested review from ezhulenev

Assignees

@gbaned gbaned

Labels

cla: yes comp:core issues related to core part of tensorflow ready to pull PR ready for merge process size:M CL Change Size: Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Solaryee @penpornk @kokoro-team @gbaned