Skip to content

Try to switch to h5py 3.1.0#45487

Merged
copybara-service[bot] merged 13 commits intotensorflow:masterfrom
bhack:h5py
Dec 11, 2020
Merged

Try to switch to h5py 3.1.0#45487
copybara-service[bot] merged 13 commits intotensorflow:masterfrom
bhack:h5py

Conversation

@bhack
Copy link
Contributor

@bhack bhack commented Dec 8, 2020

This reverts commit d36db29.

Reopen #45380 that was merged when still under tests.

/cc @mihaimaruseac

Fixes #44467

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Dec 8, 2020
@google-cla google-cla bot added the cla: yes label Dec 8, 2020
@bhack bhack mentioned this pull request Dec 8, 2020
Merged
@bhack
Copy link
Contributor Author

bhack commented Dec 8, 2020

@mihaimaruseac Please we could work here after you have investigated on the Win/Macos machine. I have allowed you edits directly in the PR

@gbaned gbaned self-assigned this Dec 9, 2020
@gbaned gbaned added the comp:lite TF Lite related issues label Dec 9, 2020
@gbaned gbaned requested a review from abattery December 9, 2020 04:57
@gbaned gbaned added the prtype:bugfix PR to fix a bug label Dec 9, 2020
@bhack
Copy link
Contributor Author

bhack commented Dec 9, 2020

I put some blackbox (as I have no access to Win/Macos machine) workarounds for windows and Macos.
Now we have only OSError: Unable to open file (unable to open file) on Windows only for the core driver test case:

      # Test non-default options in h5
      with h5py.File('_', driver='core',
                     backing_store=False) as h5file:

And a MLIR error for Macos

@bhack
Copy link
Contributor Author

bhack commented Dec 10, 2020

Very strange on Windows GPU all tests are passing.

@bhack
Copy link
Contributor Author

bhack commented Dec 10, 2020

/cc @silvasean any hint about your MLiR test on MacOS?

@silvasean
Copy link
Contributor

silvasean commented Dec 10, 2020

/cc @silvasean any hint about your MLiR test on MacOS?

Sorry, no specific hints. I ran into these kinds of random breakages and very painfully debugged them at a distance by re-running presubmits as I don't have a mac. My sympathies go out to you!

@abattery abattery removed their request for review December 10, 2020 10:14
@bhack
Copy link
Contributor Author

bhack commented Dec 10, 2020

@silvasean Thanks but it is unrelated cause it is failing with the same MLIR test also in other PRs

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 10, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 10, 2020
@copybara-service copybara-service bot merged commit 4a8d9cf into tensorflow:master Dec 11, 2020
@harupy harupy mentioned this pull request Dec 14, 2020
Merged
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gbaned gbaned

Labels

cla: yes comp:lite TF Lite related issues prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:S CL Change Size: Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

h5py==3.0.0 causes issues with keras model loads in tensorflow 2.1.0

5 participants

@bhack @silvasean @mihaimaruseac @kokoro-team @gbaned