Codecov Report

Merging #210 into develop will decrease coverage by <.01%.
The diff coverage is 64.7%.

@@             Coverage Diff             @@
##           develop     #210      +/-   ##
===========================================
- Coverage    58.99%   58.99%   -0.01%     
===========================================
  Files           58       59       +1     
  Lines         3673     3687      +14     
===========================================
+ Hits          2167     2175       +8     
- Misses        1354     1360       +6     
  Partials       152      152

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb515f...d72de8b. Read the comment docs.

LGTM! Wouldn't it make more sense to have this code in go-crypto instead of tmlibs though?

Wouldn't it make more sense to have this code in go-crypto instead of tmlibs though?

Heh, fun question. We have an ongoing discussion about how to conceptualize/consolidate our repos - tendermint/tendermint#1309

Are you proposing that all of merkle move to go-crypto or just the new tmhash ?

I wouldn't be opposed to moving all of merkle, but maybe then we'd want to move iavl as well ?!

I wouldn't be opposed to moving all of merkle, but maybe then we'd want to move iavl as well ?!

I think everything which is crypto and used in more then a single repo (hashing definitely is) should be in go-crypto, everything which is specific to dealing with an IAVL tree (like persisting in db, snapshots, the balancing algo and a few more things I forgot (?)), should stay in a separate IAVL repo (or at least package).

Cool. Let's get these fixes to the hasher and the merkle lib done in tmlibs, and then we can move the merkle package over to go-crypto.

When all said and done, this repo should be left with only: cli, common, db, log

Actually there's already breaking stuff on develop here and I want to update tendermint to use this first. Rather than muck about with branches here let's just move it to go-crypto now: tendermint/go-crypto#105