Can we start off for now just doing automated testing with the softsign (ed25519-dalek) provider? Automated testing with a physical HSM USB device would require CI integration with a server with one of those attached (unless someone has one of those? 😁). I also don't have one personally right now, so it's difficult for me to test at the moment.

@liamsi and spoke earlier and we both think there should be integration tests from both sides. Just to be explicit:

From KMS: have a CI testing step from within a Docker image with a prebuilt Tendermint binary. Instead of the tendermint/cmd/tendermint full binary, the binary built into this Docker image should be a kind of "test harness" that effectively runs some integration tests in the Golang equivalent of tests/integration.rs. We could perhaps create a separate application in the tendermint/cmd/ folder, alongside priv_val_server and tendermint. Maybe we could call it priv_val_harness? Any ideas on a good name here?

From Tendermint: have a CI testing step from within a Docker image with a prebuilt KMS binary. This binary should run some kind of test harness similar to tests/integration.rs.

Does this approach sound reasonable for now?

Using Docker images will allow explicit version control for CI from both sides. Coming up with Vagrant scripts based on the Dockerfiles shouldn't be too hard, which I'd imagine would allow for local testing with physical USB HSM devices.

Add full integration test: kms <-> tendermint #49

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions