Skip to content

switch from golangci to github actions#77

Merged
tac0turtle merged 25 commits intomasterfrom
marko/lint
Mar 16, 2020
Merged

switch from golangci to github actions#77
tac0turtle merged 25 commits intomasterfrom
marko/lint

Conversation

@tac0turtle
Copy link
Contributor

transition to githubactions run linting

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

@erikgrinaker
Copy link
Contributor

Oh no. ☹️ It might be easier to just run this in CircleCI, to avoid having to maintain too many different build systems.

@tac0turtle
Copy link
Contributor Author

was thinking of doing that as well, but think this may be simpler than waiting to add a token to our circle instance. I would also like to look at moving this repo entirely over to github actions

@tac0turtle tac0turtle marked this pull request as ready for review March 16, 2020 13:22
@tessr tessr changed the title golangci removal switch from golangci to github actions Mar 16, 2020
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tac0turtle tac0turtle added the S:automerge Status: Auto merge a pull request label Mar 16, 2020
@tac0turtle tac0turtle merged commit 0d727a5 into master Mar 16, 2020
@tac0turtle tac0turtle deleted the marko/lint branch March 16, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Status: Auto merge a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants