Skip to content

memdb: take out read-lock during iteration#74

Merged
erikgrinaker merged 3 commits intomasterfrom
erik/memdb-iterator-readlock
Mar 10, 2020
Merged

memdb: take out read-lock during iteration#74
erikgrinaker merged 3 commits intomasterfrom
erik/memdb-iterator-readlock

Conversation

@erikgrinaker
Copy link
Contributor

B-tree may panic if it is changed during iteration, so we take out a read-lock for the duration.

No tests, since concurrency semantics are undefined and differ across backends (see #62).

@erikgrinaker erikgrinaker self-assigned this Mar 10, 2020
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@erikgrinaker erikgrinaker merged commit 3ff68ea into master Mar 10, 2020
@erikgrinaker erikgrinaker deleted the erik/memdb-iterator-readlock branch March 10, 2020 17:37
nddeluca referenced this pull request in Kava-Labs/tm-db Jan 8, 2024
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.56.2 to 1.57.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.56.2...v1.57.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants