Skip to content

cleveldb: fix handling of empty iterator keys#65

Merged
erikgrinaker merged 1 commit intomasterfrom
erik/cleveldb-fixes
Mar 10, 2020
Merged

cleveldb: fix handling of empty iterator keys#65
erikgrinaker merged 1 commit intomasterfrom
erik/cleveldb-fixes

Conversation

@erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Mar 9, 2020

New tests showed that empty iterator keys causes panics.

@erikgrinaker erikgrinaker self-assigned this Mar 9, 2020
@erikgrinaker erikgrinaker changed the title cleveldb: fix handling of empty iterator keys and closed batches cleveldb: fix handling of empty iterator keys Mar 10, 2020
@erikgrinaker
Copy link
Contributor Author

@melekes Changed this to only fix the iterator bug, while I make a new PR for closed batch errors. Could you review again please?

@erikgrinaker erikgrinaker merged commit 45ff9b5 into master Mar 10, 2020
@erikgrinaker erikgrinaker deleted the erik/cleveldb-fixes branch March 10, 2020 10:34
nddeluca referenced this pull request in Kava-Labs/tm-db Jan 8, 2024
* Fix lints

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Bump minimum Go version to 1.20

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Install gcc 11

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: lasarojc <lasaro@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants