Divergences in comparison with #9620. Part 2: Improved checks for vote extension signing in the unit tests#9895
Merged
sergio-mena merged 3 commits intofeature/abci++veffrom Dec 20, 2022
Conversation
4 tasks
thanethomson
approved these changes
Dec 20, 2022
Contributor
|
Thanks for the cleanup here! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #9887
This PR comprises three steps:
signAddVotevote to make sure the votes are used properly by the testsMakeVoteimplementationssignAddVoteandMakeVoteso that they share the newly introduced checksPR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed