Divergences in comparison with #9620. Part 1: easy/obvious#9888
Merged
sergio-mena merged 2 commits intofeature/abci++veffrom Dec 16, 2022
Merged
Divergences in comparison with #9620. Part 1: easy/obvious#9888sergio-mena merged 2 commits intofeature/abci++veffrom
sergio-mena merged 2 commits intofeature/abci++veffrom
Conversation
sergio-mena
commented
Dec 15, 2022
| bytes extension_signature = 10; | ||
| } | ||
|
|
||
| // VoteExtension is app-defined additional information to the validator votes. |
Contributor
Author
There was a problem hiding this comment.
These left-overs may have caused a breakage in the block format
4 tasks
thanethomson
approved these changes
Dec 15, 2022
Co-authored-by: Thane Thomson <connect@thanethomson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #9887
These are the obvious divergences (including bugs) between #9620 and
feature/abci++vefFor more info, check #9887
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed