kvindexer/0.34/bugfixes in range queries and result deduplication#9884
Closed
jmalicevic wants to merge 8 commits intov0.34.xfrom
Closed
kvindexer/0.34/bugfixes in range queries and result deduplication#9884jmalicevic wants to merge 8 commits intov0.34.xfrom
jmalicevic wants to merge 8 commits intov0.34.xfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs when matching attributes within events:
CONTAINSandEXISTSwould ignore the height requirement whenmatch.events = 1.There have been minor improvements to the readability of the code:
heightInfostruct that encapsulates all of that. Additionally, spuradious checks on whether the length of the conditions is a certain number has been replaced with simpleboolflags which are derived within thededupHeightmethod.