Skip to content

Rejects empty transactions in the example kvstore (backport #9823)#9841

Merged
lasarojc merged 1 commit intov0.37.xfrom
mergify/bp/v0.37.x/pr-9823
Dec 6, 2022
Merged

Rejects empty transactions in the example kvstore (backport #9823)#9841
lasarojc merged 1 commit intov0.37.xfrom
mergify/bp/v0.37.x/pr-9823

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 6, 2022

This is an automatic backport of pull request #9823 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Rejects empty transactions in the example kvstore

* Add code for rejected transaction; Add test for txn rejection;

* Apply suggestions from code review

Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit 49502da)
@mergify mergify bot requested a review from ebuchman as a code owner December 6, 2022 13:01
@mergify mergify bot requested a review from a team December 6, 2022 13:01
@mergify mergify bot requested review from adizere and lasarojc as code owners December 6, 2022 13:01
@lasarojc lasarojc self-assigned this Dec 6, 2022
@lasarojc lasarojc added the S:automerge Automatically merge PR when requirements pass label Dec 6, 2022
@lasarojc lasarojc merged commit 53ac7fc into v0.37.x Dec 6, 2022
@lasarojc lasarojc deleted the mergify/bp/v0.37.x/pr-9823 branch December 6, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant