e2e: Runner is able to start and stop Tendermint testnet processes on non-local machines#9801
Closed
williambanfield wants to merge 490 commits intomainfrom
Closed
e2e: Runner is able to start and stop Tendermint testnet processes on non-local machines#9801williambanfield wants to merge 490 commits intomainfrom
williambanfield wants to merge 490 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality to the e2e runner process to start and stop tendermint nodes on non-local machines.
To achieve this goal, it makes the following set of changes:
infra.Providerinterface and implements them by both thedocker.Provideranddigitalocean.Provider. The digitalocean provider expects Tendermint to be running under systemd and is started/stopped/killed using interactions with systemd.ssh-agentto be running on the host machine and uses keys from the ssh-agent to connect to the remote. This allows operators of the e2e runner to either run the process locally or to run it on a remote orchestrator machine and grant it permission to ssh to additional nodes using ssh-agent forwarding.dockerComposeExecfunctionality to thedockerpackage. The remaining uses of this newdocker.ComposeExecfunction are all targets for replacement with provider methods.InfrastructureDataandInfrastructureTypeto the test subprocess.Closes: #9790
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed