Skip to content

Delete release_notes.md#9753

Merged
thanethomson merged 2 commits intotendermint:mainfrom
faddat:patch-11
Nov 24, 2022
Merged

Delete release_notes.md#9753
thanethomson merged 2 commits intotendermint:mainfrom
faddat:patch-11

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Nov 23, 2022

To make Tendermint consensus easier to maintain, we should remove superfluous files. This file is reasonable for the v0.34.x branch.


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@faddat faddat requested a review from ebuchman as a code owner November 23, 2022 15:49
@faddat faddat requested a review from a team November 23, 2022 15:49
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this was an artifact related to the v0.34.0 release process. At present we generate this automatically here:

- run: echo https://github.com/tendermint/tendermint/blob/${GITHUB_REF#refs/tags/}/CHANGELOG.md#${GITHUB_REF#refs/tags/} > ../release_notes.md

We should probably look at improving how those release notes are generated. It'd be nice to have it properly formatted and have a link in the release notes that clearly shows the diff between the new version and the previous one.

@thanethomson thanethomson merged commit 3e76698 into tendermint:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants