Skip to content

make format#9744

Merged
mergify[bot] merged 5 commits intotendermint:mainfrom
faddat:faddat/makeformatting
Nov 24, 2022
Merged

make format#9744
mergify[bot] merged 5 commits intotendermint:mainfrom
faddat:faddat/makeformatting

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Nov 22, 2022

NOTE: this pr exclusively runs commands from the makefile found here

This PR ONLY runs make format ... then make mockery

Its purpose is to ensure that the review scope of other PR's, which changed .go files and thus triggered the linter that only runs conditionally, have smaller review
scopes, and should be merged before:

#9738
#9739
#9742


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@faddat faddat requested a review from ebuchman as a code owner November 22, 2022 10:38
@faddat faddat requested a review from a team November 22, 2022 10:38
@faddat
Copy link
Contributor Author

faddat commented Nov 22, 2022

flaky tests....

@faddat
Copy link
Contributor Author

faddat commented Nov 22, 2022

I think this passes, if CI is run again.

@thanethomson thanethomson added the S:automerge Automatically merge PR when requirements pass label Nov 24, 2022
@mergify mergify bot merged commit 8fd66a6 into tendermint:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants