Skip to content

Remove useless whitespace in Websocket output (backport #9720)#9724

Merged
adizere merged 2 commits intov0.34.xfrom
thane/bp/v0.34.x/pr-9650
Nov 21, 2022
Merged

Remove useless whitespace in Websocket output (backport #9720)#9724
adizere merged 2 commits intov0.34.xfrom
thane/bp/v0.34.x/pr-9650

Conversation

@thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Nov 20, 2022

Not sure why Mergify failed to open the automatic backport of #9720 to v0.34.x, so I just cherry-picked the commit manually.


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

adizere and others added 2 commits November 20, 2022 10:00
* First try at #9696

* Brief explanation

* Removed all prettified JSON RPC responses

* Fixes for failing tests.

Adapted the assertions in
- TestWriteRPCResponseHTTP
- TestWriteRPCResponseHTTPError
to work with non-pretty JSON-RPC output

* Added changelog pending entry

* Update CHANGELOG_PENDING.md

Co-authored-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as ready for review November 20, 2022 15:15
@thanethomson thanethomson requested a review from a team November 20, 2022 15:15
Copy link
Contributor

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thane!

@adizere adizere merged commit 08e5d0b into v0.34.x Nov 21, 2022
@adizere adizere deleted the thane/bp/v0.34.x/pr-9650 branch November 21, 2022 11:05
Copy link

@gatleas17 gatleas17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done/Merged

Development

Successfully merging this pull request may close these issues.

3 participants