Skip to content

p2p: add a per-message type send and receive metric (backport #9622)#9641

Merged
williambanfield merged 55 commits intov0.34.xfrom
mergify/bp/v0.34.x/pr-9622
Nov 1, 2022
Merged

p2p: add a per-message type send and receive metric (backport #9622)#9641
williambanfield merged 55 commits intov0.34.xfrom
mergify/bp/v0.34.x/pr-9622

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 27, 2022

This is an automatic backport of pull request #9622 done by Mergify.
Cherry-pick of 09b8708 has failed:

On branch mergify/bp/v0.34.x/pr-9622
Your branch is up to date with 'origin/v0.34.x'.

You are currently cherry-picking commit 09b870831.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   blockchain/msgs.go
	modified:   cmd/tendermint/commands/debug/util.go
	modified:   consensus/byzantine_test.go
	modified:   consensus/invalid_test.go
	modified:   consensus/msgs_test.go
	modified:   consensus/reactor_test.go
	modified:   evidence/reactor.go
	modified:   evidence/reactor_test.go
	modified:   mempool/v0/reactor.go
	modified:   mempool/v0/reactor_test.go
	modified:   mempool/v1/reactor.go
	modified:   p2p/base_reactor.go
	modified:   p2p/conn/connection.go
	modified:   p2p/mock/peer.go
	modified:   p2p/mock/reactor.go
	modified:   p2p/mocks/peer.go
	modified:   p2p/peer.go
	modified:   p2p/peer_set_test.go
	modified:   p2p/peer_test.go
	modified:   p2p/pex/pex_reactor_test.go
	modified:   p2p/switch.go
	modified:   p2p/switch_test.go
	modified:   p2p/test_util.go
	modified:   p2p/transport.go
	modified:   p2p/types.go
	new file:   proto/tendermint/consensus/message.go
	new file:   proto/tendermint/mempool/message.go
	new file:   proto/tendermint/p2p/pex.go
	new file:   proto/tendermint/statesync/message.go
	modified:   statesync/messages.go
	modified:   statesync/messages_test.go
	modified:   statesync/reactor.go
	modified:   statesync/reactor_test.go
	modified:   statesync/syncer.go
	modified:   statesync/syncer_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   .github/workflows/lint.yml
	both modified:   blockchain/v0/reactor.go
	both modified:   cmd/tendermint/commands/rollback.go
	both modified:   consensus/msgs.go
	both modified:   consensus/reactor.go
	both modified:   go.mod
	both modified:   go.sum
	both modified:   libs/rand/random.go
	deleted by us:   p2p/metrics.gen.go
	both modified:   p2p/metrics.go
	both modified:   p2p/pex/pex_reactor.go
	added by them:   proto/tendermint/blockchain/message.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* p2p: ressurrect the p2p envelope and use to calculate message metric

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
(cherry picked from commit 09b8708)

# Conflicts:
#	.github/workflows/lint.yml
#	blockchain/v0/reactor.go
#	cmd/tendermint/commands/rollback.go
#	consensus/msgs.go
#	consensus/reactor.go
#	go.mod
#	go.sum
#	libs/rand/random.go
#	p2p/metrics.gen.go
#	p2p/metrics.go
#	p2p/pex/pex_reactor.go
#	proto/tendermint/blockchain/message.go
@mergify mergify bot requested a review from a team October 27, 2022 19:47
@mergify mergify bot added the conflicts label Oct 27, 2022
@williambanfield williambanfield force-pushed the mergify/bp/v0.34.x/pr-9622 branch from 9c8a29c to b166bf8 Compare October 28, 2022 21:33
@williambanfield williambanfield force-pushed the mergify/bp/v0.34.x/pr-9622 branch from b166bf8 to 6b33216 Compare October 31, 2022 15:37
@williambanfield williambanfield force-pushed the mergify/bp/v0.34.x/pr-9622 branch from 48a3a2e to 0e0d04f Compare October 31, 2022 21:35
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more things, but otherwise this looks great, thanks @williambanfield!

@williambanfield williambanfield force-pushed the mergify/bp/v0.34.x/pr-9622 branch 4 times, most recently from 3571d89 to 28eaef2 Compare November 1, 2022 17:40
@williambanfield williambanfield force-pushed the mergify/bp/v0.34.x/pr-9622 branch from 28eaef2 to 06e974b Compare November 1, 2022 17:54
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh one more thing, should this not have a CHANGELOG_PENDING entry?

@williambanfield williambanfield merged commit bdedf2e into v0.34.x Nov 1, 2022
@williambanfield williambanfield deleted the mergify/bp/v0.34.x/pr-9622 branch November 1, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants