p2p: add a per-message type send and receive metric (backport #9622)#9641
Merged
williambanfield merged 55 commits intov0.34.xfrom Nov 1, 2022
Merged
p2p: add a per-message type send and receive metric (backport #9622)#9641williambanfield merged 55 commits intov0.34.xfrom
williambanfield merged 55 commits intov0.34.xfrom
Conversation
* p2p: ressurrect the p2p envelope and use to calculate message metric Co-authored-by: Callum Waters <cmwaters19@gmail.com> (cherry picked from commit 09b8708) # Conflicts: # .github/workflows/lint.yml # blockchain/v0/reactor.go # cmd/tendermint/commands/rollback.go # consensus/msgs.go # consensus/reactor.go # go.mod # go.sum # libs/rand/random.go # p2p/metrics.gen.go # p2p/metrics.go # p2p/pex/pex_reactor.go # proto/tendermint/blockchain/message.go
9c8a29c to
b166bf8
Compare
b166bf8 to
6b33216
Compare
48a3a2e to
0e0d04f
Compare
thanethomson
reviewed
Nov 1, 2022
Contributor
thanethomson
left a comment
There was a problem hiding this comment.
Just a couple more things, but otherwise this looks great, thanks @williambanfield!
3571d89 to
28eaef2
Compare
28eaef2 to
06e974b
Compare
thanethomson
approved these changes
Nov 1, 2022
thanethomson
reviewed
Nov 1, 2022
Contributor
thanethomson
left a comment
There was a problem hiding this comment.
Oh one more thing, should this not have a CHANGELOG_PENDING entry?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9622 done by Mergify.
Cherry-pick of 09b8708 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com