Added back CacheControl headers from PR #6265#9549
Closed
Bro-Chain wants to merge 3 commits intotendermint:v0.34.xfrom
Closed
Added back CacheControl headers from PR #6265#9549Bro-Chain wants to merge 3 commits intotendermint:v0.34.xfrom
Bro-Chain wants to merge 3 commits intotendermint:v0.34.xfrom
Conversation
sergio-mena
reviewed
Oct 17, 2022
Contributor
|
link to PR #9442 |
sergio-mena
reviewed
Oct 18, 2022
| } | ||
|
|
||
| // Set the default response cache to true unless | ||
| // 1. Any RPC request rrror. |
Contributor
There was a problem hiding this comment.
Suggested change
| // 1. Any RPC request rrror. | |
| // 1. Any RPC request error. |
sergio-mena
previously approved these changes
Oct 18, 2022
Contributor
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks for the changes, I added one more minor comment
Contributor
|
Please add a changelog entry |
sergio-mena
reviewed
Oct 18, 2022
| } | ||
| w.Header().Set("Content-Type", "application/json") | ||
| if c { | ||
| w.Header().Set("Cache-Control", "public, max-age=86400") // expired after one year |
Contributor
I took a look at #9442. My understanding is that #9442 is equivalent to this PR (but for
|
Contributor
|
This PR is a duplicate of #9442. |
Contributor
|
Supeseded by #9650. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #5764 raised the feature request of having the RPC return Cache-Control headers when applicable. This resulted in PR #6265, which was later merged. But it was merged into master, so it never made it to release in 0.34.x. This is that patch again, but so it can actually be released.
Closes #5764 (again)
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed