blocksync: retry requests after timeout (backport #9518)#9534
Merged
sergio-mena merged 2 commits intov0.34.xfrom Oct 10, 2022
Merged
blocksync: retry requests after timeout (backport #9518)#9534sergio-mena merged 2 commits intov0.34.xfrom
sergio-mena merged 2 commits intov0.34.xfrom
Conversation
* blocksync: retry requests after timeout * Minimize changes to re-send block request after timeout * TO REVERT: reduce queue capacity * Add reset * Revert "TO REVERT: reduce queue capacity" This reverts commit dd0fee5. * 30 seconds * don't reset the timer * Update blocksync/pool.go Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Callum Waters <cmwaters19@gmail.com> (cherry picked from commit a371b1e)
sergio-mena
approved these changes
Oct 10, 2022
cmwaters
approved these changes
Oct 10, 2022
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
Can we also add a short changelog to this
Contributor
Good point. Thanks for reminding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9518 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com